|SUCCESS| common/mlx5: fix mkey ordering enum
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Oct 22 11:01:20 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/171825
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22
# DPDK Patch Review
## Errors
None identified.
## Warnings
None identified.
## Info
**Enum value removal without deprecation process:**
The patch removes `MLX5_MKC_RAW_ORDERING_SAO = 0x1` and changes `MLX5_MKC_RAW_ORDERING_RO` from `0x2` to `0x1`.
This is an API change to an enum in an installed header (`drivers/common/mlx5/mlx5_prm.h`).
However, checking the driver directory structure, `mlx5_prm.h` is not listed in the `headers` variable in `drivers/common/mlx5/meson.build`, so this is an internal header not exposed as public API. The change does not require ABI versioning or deprecation notices.
The patch correctly updates the enum to match the revised hardware specification. The fix references the original commit that introduced the incorrect values and includes `Cc: stable at dpdk.org`, which is appropriate for a hardware specification correction.
Review-Result: CLEAN
More information about the test-report
mailing list