|WARNING| cfgfile: fix isspace() undefined behavior
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Oct 22 17:10:54 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171846
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22
# DPDK Patch Review
## ERRORS
**1. Missing semicolon on line 109**
Line 109 in the patch has a syntax error:
```c
while (isspace((unsigned char)str[start]) && start < newlen)
start++
; /* do nothing */
```
The `start++` statement is missing a semicolon. This will cause a compilation failure.
**Fix:**
```c
while (isspace((unsigned char)str[start]) && start < newlen)
start++;
/* do nothing */
```
or keep the empty statement on the same line:
```c
while (isspace((unsigned char)str[start]) && start < newlen)
start++; /* do nothing */
```
## WARNINGS
None.
## INFO
None.
---
**Final Assessment:**
The patch correctly addresses a real undefined behavior bug where signed `char` values >= 0x80 are passed to `isspace()`, causing out-of-bounds table access. The cast to `(unsigned char)` is the standard idiom for this issue, matching existing DPDK practice in `test_bbdev_vector.c`.
However, the syntax error on line 109 makes the patch fail to compile. Once that semicolon is added, the fix is correct and the commit message accurately describes both the problem and the solution.
Review-Result: ERROR
More information about the test-report
mailing list