|WARNING| cfgfile: fix isspace() undefined behavior
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Oct 22 23:05:48 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/171846
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-22
# DPDK Patch Review
## ERRORS
**Missing semicolon creates compilation failure**
Line 109 in the patch:
```c
while (isspace((unsigned char)str[start]) && start < newlen)
start++
; /* do nothing */
```
The `start++` statement is missing a semicolon. This should be:
```c
while (isspace((unsigned char)str[start]) && start < newlen)
start++;
```
The stray semicolon on the next line with the comment is syntactically valid but creates a confusing empty statement. The correct fix is to place the semicolon after `start++` and either remove the comment line or keep it as a single-line comment after the loop.
---
## Review Summary
The patch correctly addresses undefined behavior in `isspace()` calls by casting to `unsigned char`. The fix is necessary and follows the correct pattern used elsewhere in DPDK (as mentioned, `app/test-bbdev/test_bbdev_vector.c` already does this). The `Fixes:` tag and `Cc: stable at dpdk.org` are appropriate for this bug fix.
However, the compilation error must be fixed before this patch can be merged.
Review-Result: ERROR
More information about the test-report
mailing list