|WARNING| pw171923 [PATCH v4-S3 04/65] dma/dpaa2: use table-driven devargs parsing
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Oct 23 15:45:13 CEST 2026
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/171923
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#101: FILE: drivers/dma/dpaa2/dpaa2_qdma.c:19:
+#define DPAA2_DEVARGS(ENTRY) \
+ ENTRY("fle_pre_populate", NULL, DPAA2_QDMA_FLE_PRE_POPULATE_FLAG) \
+ ENTRY("desc_debug", NULL, DPAA2_QDMA_DESC_DEBUG_FLAG) \
+ ENTRY("short_fd", NULL, DPAA2_QDMA_SHORT_FD_FLAG)
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
total: 1 errors, 0 warnings, 222 lines checked
__rte_packed_begin and __rte_packed_end should always be used in pairs.
More information about the test-report
mailing list