|WARNING| pw171922 [PATCH v4-S3 03/65] crypto/dpaa2_sec: use table-driven devargs parsing
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Oct 23 15:45:19 CEST 2026
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/171922
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#131: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:84:
+#define DPAA2_DEVARGS(ENTRY) \
+ ENTRY("drv_dump_mode", dpaa2_sec_devarg_dump_set, 0) \
+ ENTRY("drv_strict_order", dpaa2_sec_devarg_order_set, 0)
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
total: 1 errors, 0 warnings, 273 lines checked
More information about the test-report
mailing list