|WARNING| [v2] dts: update single core performance test configuration

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172117

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-26

# DPDK Patch Review

## ERRORS

**1. Variable overwrite before read (dead store)**

In `single_core_forward_perf()` at line 170 (after the changes):
```python
params["pass"] = float(params["performance_delta"]) >= -params.get(
    "delta_tolerance", self.delta_tolerance
)
```

The `params["pass"]` field is unconditionally assigned inside the `with` block for every test parameter.
If the testpmd context manager fails to initialize or raises an exception before this assignment,
the later verification loop at line 174 will attempt to access `params["pass"]` which may not exist,
causing a KeyError.

Suggested fix: Either initialize `params["pass"] = False` before the `with` block,
or wrap the verification in a try-except, or check for key existence before accessing:
```python
for params in self.test_parameters:
    if "pass" not in params:
        params["pass"] = False
    verify(
        params["pass"] is True,
        ...
    )
```

## WARNINGS

**1. Inconsistent delta_tolerance type in Config**

At line 65:
```python
delta_tolerance: float | None = 0.05
```

The type annotation allows `None`, but the default is `0.05`.
The code at line 169 uses `params.get("delta_tolerance", self.delta_tolerance)`,
which will fail if `self.delta_tolerance` is `None` (the negation `-self.delta_tolerance` will raise TypeError).

If `delta_tolerance` being `None` is a valid state (e.g., to require per-parameter specification),
the code must handle it explicitly. Otherwise, the type should be `float` only.

Suggested fix: Either change the type to `float` or add None-checking:
```python
delta_tolerance: float = 0.05
```

**2. Missing validation for per-parameter delta_tolerance**

The code allows `delta_tolerance` to be specified per test parameter (line 35, 56),
but there's no validation that at least one source of `delta_tolerance` exists.
If `self.delta_tolerance` is `None` and a parameter omits `delta_tolerance`,
the calculation at line 169 will fail.

Suggested fix: Add validation in `set_up_suite()`:
```python
def set_up_suite(self):
    """Set up the test suite."""
    self.test_parameters = self.config.test_parameters
    self.traffic_duration = self.config.traffic_duration
    self.test_repetitions = self.config.test_repetitions
    self.delta_tolerance = self.config.delta_tolerance
    
    # Validate that each parameter has a delta_tolerance
    for params in self.test_parameters:
        if "delta_tolerance" not in params and self.delta_tolerance is None:
            raise ValueError(
                "delta_tolerance must be specified globally or per-parameter"
            )
```

## INFO

**1. Consider making traffic_duration and test_repetitions have defaults in Config**

The Config fields `traffic_duration` and `test_repetitions` have defaults of 5,
which matches the documentation in `tests_config.example.yaml`.
This is good design and consistent with the documented behavior.

**2. Documentation formatting**

In `test_run.example.yaml` at line 37:
```yaml
#     The number of core to provide TREX traffic generator.
```

Minor typo: "core" should be "cores" to match the field name and match plural usage.

**3. Example config clarity**

The example at lines 25 and 56 shows `delta_tolerance` specified both at the suite level
and per-parameter. Consider adding a comment in the example explaining the precedence
(per-parameter overrides suite-level), which is clear from the code but not from the example alone.

---

Review-Result: WARNING