|WARNING| [v2] dts: update single core performance test configuration

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172117

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-26

# DPDK Patch Review

## ERRORS

**1. Uninitialized variable use in error path**

File: `dts/tests/TestSuite_single_core_forward_perf.py`, line 169

The variable `params` is undefined if `self.test_parameters` is an empty list. The loop starting at line 158 would not execute, leaving `params` uninitialized when the verification loop at line 174 attempts to access it.

```python
for params in self.test_parameters:
    verify(
        params["pass"] is True,
        ...
    )
```

**Suggested fix:** Guard the verification loop or ensure `test_parameters` is non-empty during setup:

```python
if not self.test_parameters:
    self.verify(False, "No test parameters configured")

for params in self.test_parameters:
    # ... existing testpmd code ...

for params in self.test_parameters:
    verify(
        params["pass"] is True,
        ...
    )
```

**2. Type mismatch in delta_tolerance handling**

File: `dts/tests/TestSuite_single_core_forward_perf.py`, lines 168-170, 177-178

The code uses `params.get("delta_tolerance", self.delta_tolerance)` where `self.delta_tolerance` is declared as `float | None = 0.05`. If `self.delta_tolerance` is `None`, this will pass `None` to the comparison and arithmetic operations, causing a `TypeError` at runtime.

Line 168:
```python
params["pass"] = float(params["performance_delta"]) >= -params.get(
    "delta_tolerance", self.delta_tolerance
)
```

Line 177:
```python
f"""Packets forwarded is less than {
    (1 - params.get("delta_tolerance", self.delta_tolerance)) * 100
}%
```

**Suggested fix:** Either ensure `delta_tolerance` is never `None`, or provide an explicit non-None fallback:

```python
# In Config class:
delta_tolerance: float = 0.05  # Remove | None

# Or in the test method:
tolerance = params.get("delta_tolerance", self.delta_tolerance or 0.05)
params["pass"] = float(params["performance_delta"]) >= -tolerance
```

---

## WARNINGS

**1. New configuration field without release notes**

The patch adds new configuration fields (`cores`, `traffic_duration`, `test_repetitions`, `delta_tolerance` at per-test level) that affect the public test configuration schema. These changes should be documented in release notes to inform users of the new capabilities.

**Suggested fix:** Add an entry to `doc/guides/rel_notes/release_<version>.rst` describing the new configuration options.

**2. Missing type annotations in dictionary**

File: `dts/tests/TestSuite_single_core_forward_perf.py`, line 34

The `test_parameters` list contains dictionaries with mixed types (`int | float`), but the new `delta_tolerance` field added to individual entries (line 35) is not reflected in the type annotation.

Current annotation:
```python
test_parameters: list[dict[str, int | float]] = [
```

The dictionaries now contain `int`, `float`, and the optional `delta_tolerance: float`, but the type doesn't capture the optional nature of the delta_tolerance key.

**Suggested fix:** Use TypedDict for better type safety:

```python
from typing import TypedDict, NotRequired

class TestParameters(TypedDict):
    frame_size: int
    num_descriptors: int
    expected_mpps: float
    delta_tolerance: NotRequired[float]

test_parameters: list[TestParameters] = [...]
```

---

## INFO

**1. Inconsistent use of delta_tolerance defaults**

The patch allows `delta_tolerance` to be specified both globally (at suite level) and per-test (within individual test parameter dictionaries). The global default is `0.05`, but the code uses `params.get("delta_tolerance", self.delta_tolerance)` which could return `None` if the suite-level tolerance is unset.

While this is handled by the type error noted above, the design intent is unclear: should the global tolerance be mandatory, or should there be a hardcoded fallback when both are absent?

**Observation:** Consider documenting the precedence order explicitly in the configuration example or enforcing that at least one tolerance value must be set.

---

Review-Result: ERROR