|WARNING| [v1, 4/4] test/fib6: reproduce table overwrite on address wraparound

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/172136

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-27

# Code Review for DPDK FIB Wraparound Bug Fix

## ERRORS

None identified.

## WARNINGS

**lib/fib/dir24_8.c (Patch 1/4) - Comment Style**

The multi-line comment added at lines 439-442 should follow DPDK style with leading asterisks:

```c
/* Current code:
 *
 * we got to the end of address space
 * and wrapped around
 */

/* Should be:
 *
 * We got to the end of address space
 * and wrapped around.
 */
```

DPDK multi-line comments require leading `*` on continuation lines and should be complete sentences with proper capitalization and punctuation.

**lib/fib/trie.c (Patch 2/4) - Comment Style**

Same issue as above - the multi-line comment added at lines 509-512 should follow DPDK style:

```c
/* Should be:
 *
 * We got to the end of address space
 * and wrapped around.
 */
```

## INFO

**Test Coverage (Patches 3/4 and 4/4)**

The new test functions `test_wraparound()` in both `test_fib.c` and `test_fib6.c` provide good coverage for the fixed bug, testing both the "delete default route" case and the "add covering prefix" case. The tests verify that lookups return correct results after the operations that previously triggered table corruption.

**Code Correctness**

The fixes in patches 1/4 and 2/4 correctly address the wraparound issue:
- In `lib/fib/dir24_8.c`: The added check `if (ledge == 0) break;` prevents the loop from continuing after `ledge` wraps around from 0xFFFFFFFF to 0.
- In `lib/fib/trie.c`: The added check `if (rte_ipv6_addr_is_unspec(&ledge)) break;` prevents the loop from continuing after `ledge` wraps from `ffff:...:ffff` to `::`.

Both fixes mirror the existing wraparound checks in the other branch of the same function, maintaining consistency.

**Fixes Tags**

All patches correctly include `Fixes:` tags pointing to the commits that introduced the bugs, and `Cc: stable at dpdk.org` tags for backporting.

---

Review-Result: WARNING