|SUCCESS| [v1, 4/4] test/fib6: reproduce table overwrite on address wraparound

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172136

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-27

# DPDK Patch Review

## Patch 1/4: fib: fix full table overwrite on address wraparound

**File:** `lib/fib/dir24_8.c`

### ERRORS

None.

### WARNINGS

None.

### INFO

**Pre-existing code observation:**
The commit message references prior commit ab1b927cd73e as having added a wraparound check to "the other branch."
Reading the added code, it mirrors the existing wraparound check pattern from that earlier fix.
The fix is correct and consistent with the established approach.

---

## Patch 2/4: fib6: fix full table overwrite on address wraparound

**File:** `lib/fib/trie.c`

### ERRORS

None.

### WARNINGS

None.

### INFO

**Pre-existing code observation:**
The commit message references commit fd66617c5774 as having added a wraparound check to "the other branch" only.
The fix adds the same check to the equal-edges branch, matching the established pattern.
The fix is correct and consistent with the fib (IPv4) equivalent.

---

## Patch 3/4: test/fib: reproduce table overwrite on address wraparound

**File:** `app/test/test_fib.c`

### ERRORS

None.

### WARNINGS

None.

### INFO

The test correctly exercises both failure scenarios described in the commit message:
- Case A: deleting a default route when the space is fully covered by /1 routes
- Case B: adding a /24 over two /25 routes at the top of the address space

The test validates that unrelated routes remain intact and that the table is not corrupted.

---

## Patch 4/4: test/fib6: reproduce table overwrite on address wraparound

**File:** `app/test/test_fib6.c`

### ERRORS

None.

### WARNINGS

None.

### INFO

The test correctly exercises the IPv6 equivalent of the scenarios in patch 3:
- Case A: deleting ::/0 when covered by ::/1 and 8000::/1
- Case B: adding a /120 over two /121 routes at the top of the IPv6 address space

The test validates that the table is not corrupted by the wraparound condition.

---

## Summary

This patch series fixes a critical correctness bug in both fib and fib6 libraries where address wraparound at the end of the address space causes silent corruption of the entire routing table. The fixes add wraparound checks to the equal-edges branch of the modify functions, mirroring the checks already present in the other branch from earlier fixes.

The test cases provide good coverage of the bug scenarios and confirm the fix works correctly. All patches are well-documented with clear commit messages and include appropriate `Fixes:` and `Cc: stable at dpdk.org` tags.

No correctness bugs, style violations, or process issues identified.

Review-Result: CLEAN