|SUCCESS| common/cnxk: handle increased count eot width for cn20k
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Fri Oct 30 08:09:19 CET 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/172272
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-10-30
# DPDK Patch Review
## ERRORS
None.
## WARNINGS
None.
## INFO
**Spacing around shift operator (style consistency):**
Lines 518 and 561 add spaces around the `!!` operator: `(uint64_t) !!fabs` (with space after cast), while the original code used `(uint64_t)!!fabs` (no space). This is purely cosmetic and both forms are acceptable, but the change is inconsistent with the surrounding style.
**Helpful context added in comments:**
The patch adds clear explanatory comments about COUNT_EOT field width differences between CN10K and CN20K, and why a 2-bit value is safe on both. This improves maintainability.
**Bit field notation update:**
The ASCII-art diagrams are updated to reflect the actual 2-bit width of COUNT_EOT on CN20K (bits 32-33), which is a documentation improvement even though the code already worked on CN10K due to the ignored reserved bit.
---
The patch correctly extends the COUNT_EOT bitmask from 1-bit (`0x1`) to 2-bit (`0x3`) to support CN20K hardware while remaining backward-compatible with CN10K (where bit 33 is reserved and ignored). The change is localized to the immediate field writes and does not affect resource management, error paths, or synchronization. No new API is introduced and no ABI is changed. Release notes are not required for this internal driver change.
Review-Result: CLEAN
More information about the test-report
mailing list