|WARNING| telemetry: promote experimental API to stable
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Sep 3 02:02:48 CEST 2026
Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168950
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-03
# DPDK Patch Review
## Summary
This patch promotes three telemetry functions from experimental to stable API. The changes are minimal and appropriate for an API promotion.
---
## Errors
None found.
---
## Warnings
None found.
---
## Info
### Documentation and Process
1. **Release notes update is appropriate**: The patch correctly documents the API promotion in the current release notes file (`release_26_11.rst`) with the list of promoted functions.
2. **Export symbol changes are correct**: The patch properly changes from `RTE_EXPORT_EXPERIMENTAL_SYMBOL(name, version)` to `RTE_EXPORT_SYMBOL(name)` for all three functions:
- `rte_telemetry_register_cmd_arg` (24.11 - stable)
- `rte_tel_data_add_array_uint_hex` (23.03 - stable)
- `rte_tel_data_add_dict_uint_hex` (23.03 - stable)
3. **Header file cleanup is correct**: Removal of `__rte_experimental` attributes from the three function declarations in `rte_telemetry.h` is appropriate.
### Style and Correctness
The patch follows DPDK conventions:
- Does not manually edit `version.map` files (correct - these are auto-generated)
- Updates export macros in `.c` files only
- Maintains consistent formatting
- No code logic changes, only API stability annotations
### Justification
The commit message provides reasonable justification:
- Hexadecimal helpers stable since v23.03 (3+ years in this future scenario)
- `rte_telemetry_register_cmd_arg` stable since v24.11 (~2 years)
This timeframe is sufficient for API stabilization.
---
## Overall Assessment
**APPROVED** - This is a clean API promotion patch with appropriate documentation, correct symbol export changes, and no code correctness issues. The patch is ready for integration.
More information about the test-report
mailing list