|WARNING| telemetry: promote experimental API to stable

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/168950

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-03

# Review of DPDK Patch: telemetry: promote experimental API to stable

## Summary

This patch promotes three telemetry functions from experimental to stable API. The changes are straightforward and follow the correct process for API stabilization.

---

## Errors

None found.

---

## Warnings

**1. Missing ABI section in release notes**

The release notes document API promotion under "API Changes" but there is no corresponding entry in the "ABI Changes" section. When symbols move from experimental to stable, this affects the ABI and should be documented in both sections.

**Suggested fix:**
Add an entry to the ABI Changes section:

```rst
ABI Changes
-----------

* telemetry: The following functions were moved from the experimental
  to the stable ABI:

  * ``rte_tel_data_add_array_uint_hex``
  * ``rte_tel_data_add_dict_uint_hex``
  * ``rte_telemetry_register_cmd_arg``
```

---

## Info

**1. Symbol export macro changes are correct**

The patch correctly changes:
- `RTE_EXPORT_EXPERIMENTAL_SYMBOL(name, version)` - `RTE_EXPORT_SYMBOL(name)`

This follows the documented pattern for promoting experimental symbols to stable.

**2. Header file changes are appropriate**

Removal of `__rte_experimental` markers from the function declarations in `rte_telemetry.h` is correct. The functions are now part of the stable API.

**3. Release notes format**

The API Changes section follows the proper format and clearly documents which functions are being promoted.

---

## Observations

- The patch is internally consistent: all three functions are promoted together in the header, implementation, and release notes
- The functions have been experimental for an appropriate duration (since v23.03 for the hex helpers, v24.11 for `register_cmd_arg`)
- No code changes beyond symbol promotion, which is appropriate for an API stability change
- The patch correctly maintains alphabetical ordering in the release notes list

---

## Conclusion

The patch is correct and follows DPDK contribution guidelines for API promotion. The only improvement needed is adding an ABI Changes section to the release notes to fully document the impact of this change.