|WARNING| net/bnxt: remove redundant VNIC NULL check

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169572

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Summary
This patch removes a redundant NULL check for VNIC objects in the bnxt driver. The check is indeed dead code since `vnic` is assigned the address of an array element (`&bp->vnic_info[i]`), which cannot be NULL.

## Findings

### Errors

None.

### Warnings

**Missing error label cleanup analysis:**

The patch removes a `goto err_out;` statement. While the removed NULL check is correctly identified as dead code, verify that the error handling path at `err_out` is still reachable from other error conditions in this function, or if it has become unreachable dead code itself.

If `err_out` is now unreachable after this change, the label and its cleanup code should also be removed in this patch or a follow-up to avoid maintaining dead error handling paths.

### Info

**Patch correctness:**

The analysis is correct. After commit 51fafb89a9a, VNICs are allocated as an array (`bp->vnic_info`), and taking the address of an array element with `&bp->vnic_info[i]` yields a non-NULL pointer by definition (assuming the array itself exists). The NULL check was only meaningful when VNICs were dynamically allocated individual objects.

**Code quality:**

The patch improves code clarity by removing a confusing check that could never be true, reducing cognitive load for future maintainers.

---

## Recommendation

**Accept** with consideration for checking whether the `err_out` label and its associated cleanup code are still necessary. If the removed `goto` was the only path to that label, include cleanup of the now-unreachable error handling in this patch or note it for follow-up.