|WARNING| net/bnxt: remove redundant VNIC NULL check

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169572

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Patch Summary
The patch removes a NULL check for VNIC objects that are obtained from an array element (address-of-array-element cannot be NULL).

---

## Review Findings

### Errors

None.

### Warnings

**1. Missing release notes entry**

This patch fixes a bug (dead code removal after a previous refactor) but does not update the release notes. While dead code removal is typically a minor fix, it does change the driver's error handling path (removes an error return point), which could be worth documenting.

**Suggested action:**
Consider adding a brief note in `doc/guides/rel_notes/release_25_03.rst` (or current release) under the bnxt driver section:

```rst
* **Updated Broadcom bnxt driver.**

  * Removed unreachable VNIC NULL check after switching to array-based allocation.
```

However, if the project policy is to not document such minor internal cleanups, this can be omitted.

---

### Info

**1. Code change is correct**

The analysis is accurate: after commit 51fafb89a9a, VNICs are accessed via:
```c
vnic = &bp->vnic_info[i];
```

The address-of operator on an array element cannot produce NULL, making the check dead code. The removal is correct.

**2. Error path cleanup**

The patch removes the `goto err_out;` on the impossible NULL case. Verify that `err_out` is still reachable from other error paths in `bnxt_mq_rx_configure()` if it performs cleanup. If `err_out` becomes unreachable after this change, it may also be removable in a follow-up patch (not required for this patch).

---

## Summary

The patch correctly removes dead code. The only consideration is whether a release notes entry is warranted for this minor internal cleanup. The change itself is valid and improves code clarity by removing impossible error handling.

**Recommendation:** Accept the patch. Release notes entry is optional depending on project policy for minor fixes.