|WARNING| net/iavf: remove redundant assignment in FDIR parser

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169576

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Patch Summary
- **Subject**: net/iavf: remove redundant assignment in FDIR parser
- **Changes**: Removes a dead store to `next_type` variable in the IPv4 parsing case

---

## Review Findings

### Correctness Issues

**None identified.**

The patch removes a variable assignment (`next_type = (item + 1)->type;`) that is never subsequently read before being overwritten or going out of scope. This is indeed a dead store, which SVACE correctly identified.

I verified the code flow around this removal:
- The variable `next_type` is assigned but not used in the remainder of the `case RTE_FLOW_ITEM_TYPE_IPV4:` block
- The variable would be reassigned (or unused) in subsequent iterations or branches
- The removal does not affect program correctness

### Code Style Issues

**None identified.**

The patch follows DPDK coding style:
- Single-line removal with proper formatting
- No style violations introduced

### API and Documentation Requirements

**Warning: Missing release notes entry**

This is a bug fix (removes dead code/confusing assignment), but does not require release notes because:
- It's an internal change to driver code
- No user-visible behavior changes
- No API or ABI impacts
- The assignment removal is purely a code cleanup

However, the patch includes `Cc: stable at dpdk.org`, which is appropriate for backporting to stable branches.

### Process Compliance

**Info: Patch targets stable backport**

The patch is correctly tagged for stable backport (`Cc: stable at dpdk.org`). The dead store removal is safe for backporting as it has no functional impact and removes potentially confusing code.

---

## Summary

**Overall Assessment**: The patch is correct and appropriate. The removal of the dead store improves code clarity with no functional changes.

**Recommendation**: Accept

The patch:
-  Correctly identifies and removes a dead store
-  Has no impact on correctness or behavior
-  Follows DPDK coding style
-  Appropriately tagged for stable backport
-  No API/ABI concerns

No changes required.