|WARNING| net/iavf: remove redundant assignment in FDIR parser

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169576

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-15

# DPDK Patch Review

## Patch Summary
The patch removes a dead assignment to `next_type` variable in the iavf FDIR parser. The variable is assigned but never read in the RTE_FLOW_ITEM_TYPE_IPV4 case branch.

## Review Findings

### CORRECTNESS: No Issues Found

**Resource Management**: No resources allocated or freed in this change.

**Logic**: The removed assignment appears to be copy-paste residue from other case branches where `next_type` is used. Static analysis correctly identified this as a dead store.

**Error Handling**: No error path modifications.

### CODE STYLE: No Issues Found

**Coding Standards**: The change follows DPDK style guidelines (removal only, no new code added).

**Forbidden Patterns**: None introduced.

### API AND DOCUMENTATION: No Issues Found

**API Changes**: None - this is an internal implementation cleanup.

**Documentation**: No documentation changes needed for this internal cleanup.

**Release Notes**: Not required - this is a non-functional internal change (dead code removal) with no user-visible impact.

### PROCESS COMPLIANCE: No Issues Found

**Compilation**: Removing an unused assignment will not break compilation.

**Testing**: No new tests required - this is dead code removal with no behavioral change.

## Conclusion

**APPROVED** - This is a valid cleanup patch that removes genuinely unused code. The assignment to `next_type` is:
1. Not used anywhere after the assignment in this case branch
2. Appears to be leftover from copy-paste of another case branch pattern
3. Correctly identified by SVACE static analyzer

The change improves code clarity by removing misleading dead code. No functional changes are introduced, and no guideline violations are present.