|WARNING| net/bnxt: fix forcing of mbuf fast free

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169868

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-21

# DPDK Patch Review

## Summary
This patch fixes a bug where the bnxt driver forced `RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE` on all non-PTP Tx queues, ignoring the application's explicit configuration. The fix tracks whether the offload was requested at queue setup and only re-enables it in `bnxt_dev_start_op()` when appropriate.

---

## Correctness Review

### Warnings

**1. Mismatch between boolean variable and non-boolean comparison context**

In `bnxt_txq.c` line 180-181:
```c
txq->fast_free_requested =
    (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0;
```

The field `txq->fast_free_requested` is declared as `bool` (correct choice for a true/false flag), but the assignment uses an explicit `!= 0` comparison. This is inconsistent: boolean variables should be assigned the result of a boolean expression directly, not through explicit comparison.

**Suggested fix:**
```c
txq->fast_free_requested =
    !!(txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE);
```
or
```c
txq->fast_free_requested =
    (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) ? true : false;
```
or simply (relying on C's implicit conversion from non-zero to true):
```c
txq->fast_free_requested =
    txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
```

The last form is cleanest and consistent with DPDK's boolean usage guidelines.

**2. Missing release notes update**

This patch fixes a functional bug that affects application behavior: applications that explicitly disabled `RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE` were having their configuration ignored. This is a user-visible behavioral change that should be documented in the current release notes under "Fixed Issues" or "Bug Fixes" for the bnxt driver.

**Suggested action:** Add an entry to `doc/guides/rel_notes/release_XX_XX.rst` (current release) documenting the fix.

---

## Style Review

### Info

**1. Boolean usage is correct**

The use of `bool fast_free_requested;` in the structure (bnxt_txq.h line 25) is good practice. This field holds only true/false values, and `bool` makes the intent clear.

The usage in bnxt_ethdev.c line 1942:
```c
if (txq->fast_free_requested)
```
is the correct pattern for boolean variables (direct truthiness check, not `== true`).

---

## Code Quality

No issues found:
- Each commit compiles independently (single patch)
- Code and logic are consistent
- The fix correctly addresses the root cause: it preserves the user's intent from queue setup and respects it at device start
- No resource leaks, use-after-free, or race conditions introduced
- No forbidden tokens used
- Naming conventions followed

---

## Final Recommendation

**Overall assessment:** The patch is functionally correct and solves a real bug. The warnings above are minor style/process issues that should be addressed:

1. **Fix the boolean assignment** to use idiomatic C boolean conversion
2. **Add a release notes entry** documenting the user-visible fix

After addressing these two warnings, the patch will be ready for merge.