|WARNING| net/bnxt: fix forcing of mbuf fast free

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169868

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-21

# DPDK Patch Review

## Patch Summary
This patch fixes a bug in the bnxt PMD where `RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE` was unconditionally enabled on every non-PTP Tx queue at `dev_start`, overriding the application's explicit offload configuration.

---

## Correctness Issues

**No correctness bugs identified.**

The patch correctly:
- Tracks the application's original offload request at queue setup time
- Only re-enables the fast-free offload at device start if it was originally requested
- Does not introduce resource leaks, use-after-free, or race conditions

---

## C Coding Style

### Info: Boolean comparison style (1 location)

**drivers/net/bnxt/bnxt_txq.c:180-181**

```c
txq->fast_free_requested =
	(txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) != 0;
```

DPDK style uses explicit comparison for integers, but for `bool` assignments from bitmask tests, the explicit `!= 0` is acceptable. However, the result can be simplified:

```c
txq->fast_free_requested =
	txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
```

The bitwise-AND result is already suitable for boolean context (non-zero = true).

---

## API and Documentation

### Warning: Missing release notes update

**Required for API/behavior change.**

This patch fixes a user-visible behavior bug: applications that intentionally disabled `RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE` will now have their configuration honored, whereas before it was silently overridden.

This change should be documented in the "Fixed Issues" section of the current release notes under `doc/guides/rel_notes/release_25_XX.rst` (where XX is the current development release), for example:

```rst
* **net/bnxt: Fixed forced mbuf fast free offload.**

  The bnxt PMD no longer unconditionally enables
  ``RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE`` at device start,
  respecting the application's offload configuration.
```

---

## Structure and Correctness

**No issues.**

- The patch correctly tracks state at queue setup and uses it at device start
- The `bool` type for `fast_free_requested` is appropriate (stores a true/false value)
- The logic preserves existing behavior when the offload was requested
- The fix is minimal and does not introduce unrelated changes

---

## Overall Assessment

**This is a correct and well-targeted fix.** The only findings are:

1. **(Info)** Minor style simplification available for the boolean assignment
2. **(Warning)** Missing release notes entry for a user-visible bug fix

The correctness of the patch is solid. The style item is cosmetic, and the release notes update is the only required change.