|WARNING| net: revert add IPv6 traffic class and flow label fields

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169937

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-22

# Review of DPDK Patch: net: revert add IPv6 traffic class and flow label fields

## Errors

None.

## Warnings

**1. Release notes placement**

The removal is documented under "Removed Items" but should also be noted under "API Changes" since this affects the public API structure `rte_ipv6_hdr`. The current documentation only lists it as a removal without explaining the impact on API users.

Suggested addition to "API Changes" section:
```rst
* net: Removed bitfields from ``struct rte_ipv6_hdr`` due to incorrect 
  little-endian implementation. Applications accessing IPv6 header fields
  must use the ``vtc_flow`` field directly with appropriate bit masks.
```

**2. Missing upgrade/migration guidance**

The release notes should include guidance for users who were relying on the removed bitfields. Consider adding a note explaining how to access these fields using bit operations on `vtc_flow`.

Example addition:
```rst
Applications that used the removed bitfields should migrate to accessing
the ``vtc_flow`` field directly using bit masks and byte order conversion,
or use the existing helper functions ``rte_ipv6_traffic_class()`` and
``rte_ipv6_ecn()`` if available.
```

## Info

**1. Explanation quality**

The commit message provides excellent technical detail about why the bitfield approach fails on little-endian architectures. The concrete example with the `struct example` is particularly helpful for understanding the issue.

**2. Compiler attribute note**

The mention of GCC's `scalar_storage_order` attribute is informative. This documents why a compiler-specific workaround wasn't chosen, which is valuable for future reference.

**3. Patch appropriateness**

Reverting the defective implementation is the correct action. Bitfields crossing byte boundaries in network byte order structures are fundamentally incompatible with C's little-endian bitfield layout rules.

## Summary

The patch correctly reverts a defective implementation that cannot work portably. The code changes are appropriate. The release notes need minor additions to properly document the API impact and provide migration guidance for affected users.