|WARNING| net: revert add IPv6 traffic class and flow label fields

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: WARNING
https://dpdk.org/patch/169937

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-22

# DPDK Patch Review

## Summary

This patch reverts a previous change that added bitfields to the IPv6 header structure. The revert is justified due to incorrect bitfield organization on little-endian architectures. The patch includes proper documentation of the issue and appropriate release notes.

---

## Errors

None found.

---

## Warnings

None found.

---

## Info

### Positive Aspects

1. **Well-documented rationale**: The commit message includes a clear explanation with concrete examples showing why the bitfields are broken on little-endian systems.

2. **Proper release notes**: The removal is correctly documented in the release notes with a clear description of what is being removed.

3. **Appropriate revert**: Rather than attempting a broken workaround, the patch cleanly reverts to the working state.

4. **Correct tags**: Includes proper `Fixes:`, `Cc: stable at dpdk.org`, `Reported-by:`, and review tags.

### General Observations

The patch demonstrates the fundamental problem with attempting to use C bitfields for network protocol headers on multi-endian architectures. The union approach with bitfields cannot work correctly because:

1. C bitfield layout is implementation-defined for the order bits are packed within storage units
2. When bitfields cross byte boundaries on little-endian systems, the bits don't map linearly to the network byte order
3. No portable solution exists without compiler-specific attributes

The revert returns to using `rte_be32_t vtc_flow` as an opaque field, which applications can manipulate using appropriate macros/functions that handle byte order correctly. This is the standard DPDK approach for protocol headers.

---

## Conclusion

**ACCEPT** - This is a correct revert of broken functionality. The patch properly documents the issue, includes appropriate release notes, and restores the code to a working state. No changes needed.