|SUCCESS| [2/2] net/cnxk: remove redundant IP reassembly conf get stubs
dpdklab at iol.unh.edu
dpdklab at iol.unh.edu
Thu Sep 24 18:34:30 CEST 2026
Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170024
_AI Code Review_
=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-24
# Review of DPDK Patch Series
## Patch 1/2: net/nfp: remove redundant link up/down stubs
### Correctness
No issues found. The patch removes stub functions that only returned `-ENOTSUP`. The ethdev core already provides this behavior when the operation is NULL, so the removal is functionally equivalent.
### Style
No issues found.
### API and Documentation
No issues found. This is an internal driver cleanup with no API impact. Release notes are not required for this type of change.
---
## Patch 2/2: net/cnxk: remove redundant IP reassembly conf get stubs
### Correctness
No issues found. Similar to patch 1, this removes stub functions returning `-ENOTSUP` where the ethdev core provides equivalent behavior for NULL operations.
### Style
No issues found.
### API and Documentation
No issues found. Internal driver cleanup with no user-facing changes.
---
## Summary
Both patches are clean removals of redundant stub functions. The changes are correct and align with DPDK's design principle that returning `-ENOTSUP` from the ethdev core for NULL operation pointers is preferred over maintaining do-nothing stubs in drivers.
**No errors, warnings, or issues found.**
More information about the test-report
mailing list