|SUCCESS| [2/2] net/cnxk: remove redundant IP reassembly conf get stubs

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170024

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-24

# Review of DPDK Patch Series

## PATCH 1/2: net/nfp: remove redundant link up/down stubs

### Summary
This patch removes VF stub functions that only return `-ENOTSUP`, relying on the ethdev layer's default behavior when the ops pointer is NULL.

### Findings

**Info:**

1. **Rationale correctness**
   The commit message correctly states that `rte_eth_dev_set_link_up()` and `rte_eth_dev_set_link_down()` return `-ENOTSUP` when the dev_ops entry is NULL. This is accurate per the ethdev implementation.

2. **Scope clarification**
   The commit message properly clarifies that this change affects only the VF ops table (`nfp_netvf_eth_dev_ops`) and that the PF table in `nfp_ethdev.c` retains its real implementations. Good separation of concerns.

**No issues found.** This patch correctly removes redundant stub functions. The VF-specific scope is appropriate, and the behavior for applications remains unchanged.

---

## PATCH 2/2: net/cnxk: remove redundant IP reassembly conf get stubs

### Summary
This patch removes two functions (`cn10k_nix_reassembly_conf_get()` and `cn20k_nix_reassembly_conf_get()`) that only return `-ENOTSUP`, relying on the ethdev layer's default behavior.

### Findings

**Info:**

1. **Rationale correctness**
   The commit message correctly states that dropping the assignments leaves the field NULL and `rte_eth_ip_reassembly_conf_get()` returns `-ENOTSUP` as before. This matches the ethdev implementation pattern.

2. **Sibling operations preserved**
   The commit message appropriately notes that `ip_reassembly_conf_set` and `ip_reassembly_capability_get` are real implementations and are intentionally left alone.

3. **Consistent pattern across chip variants**
   Both `cn10k` and `cn20k` variants are handled identically, maintaining consistency.

**No issues found.** This patch correctly removes redundant stub functions. The sibling operations with real functionality are appropriately preserved.

---

## Series-Level Assessment

Both patches follow the same optimization pattern: removing stub functions that provide no value beyond what the ethdev layer already provides by default. The changes are:

- **Correct:** The behavior for applications is preserved (same `-ENOTSUP` return value)
- **Cleanup:** Reduces code size and maintenance burden
- **Consistent:** Both patches apply the same principle to different drivers
- **Safe:** No ABI or API changes; purely internal driver implementation detail

**No errors, warnings, or actionable issues found in this patch series.**