|SUCCESS| [2/2] net/cnxk: remove redundant IP reassembly conf get stubs

[dpdklab at iol.unh.edu]

Test-Label: ai-code-review
Test-Status: SUCCESS
https://dpdk.org/patch/170024

_AI Code Review_

=== Patch Review: series.patch (via Claude) ===
Review date: 2026-09-24

# DPDK Patch Review

## Overall Assessment

This patch series removes stub functions that return only `-ENOTSUP` and instead relies on the ethdev layer to return `-ENOTSUP` when the dev_ops field is NULL. Both patches are correct and follow good DPDK practice.

---

## Patch 1/2: net/nfp: remove redundant link up/down stubs

**No issues found.**

The patch correctly removes `nfp_netvf_set_link_up()` and `nfp_netvf_set_link_down()` stub functions. The commit message accurately explains that `rte_eth_dev_set_link_up()` and `rte_eth_dev_set_link_down()` return `-ENOTSUP` when the dev_ops entry is NULL, making these stubs redundant. The note clarifying that these are VF-only and the PF implementations are preserved is helpful context.

---

## Patch 2/2: net/cnxk: remove redundant IP reassembly conf get stubs

**No issues found.**

The patch correctly removes `cn10k_nix_reassembly_conf_get()` and `cn20k_nix_reassembly_conf_get()` stub functions. The explanation that `rte_eth_ip_reassembly_conf_get()` returns `-ENOTSUP` when the ops field is NULL is correct. The note that the sibling `ip_reassembly_conf_set` and `ip_reassembly_capability_get` ops remain as real implementations is appropriate context.

---

## Summary

Both patches in this series are clean refactorings that reduce unnecessary code. They rely on the ethdev layer's existing behavior of returning `-ENOTSUP` when dev_ops callbacks are not provided, which is the standard DPDK pattern. No correctness issues, style violations, or documentation gaps were found.